feat: Update to Angular 15 #303
Conversation
JeanMeche
requested review from
daileytj and
JeffGreiner-eaton
as code owners
|
Hi all, started looking things over since the angular-themes alpha is in here. It might be better to develop against a running dev branch along side this feature branch or you can use this deployed version if it makes it easier. this is just a quick overview of what I see, so I would check against everything because there are more that I didn't capture. Some items I've noticed
|
|
just adding this warning I viewed in the terminal while starting the showcase..
|
|
Thx @JeffGreiner-eaton I'll have a look 👍 |
JeffGreiner-eaton
added
the
brightlayer-ui
| .blui-blue-dark { | ||
| $blui-blue-dark-primary: theme-bases.$blui-blue-dark-primary; | ||
| $blui-blue-dark-accent: theme-bases.$blui-blue-dark-accent; | ||
| $blui-blue-dark-warn: theme-bases.$blui-blue-dark-warn; | ||
| // .blui-blue-dark { | ||
| // $blui-blue-dark-primary: theme-bases.$blui-blue-dark-primary; | ||
| // $blui-blue-dark-accent: theme-bases.$blui-blue-dark-accent; | ||
| // $blui-blue-dark-warn: theme-bases.$blui-blue-dark-warn; | ||
|
|
||
| @include theme-bases.dark-theme($blui-blue-dark-primary, $blui-blue-dark-accent, $blui-blue-dark-warn); | ||
| } | ||
| // @include theme-bases.dark-theme($blui-blue-dark-primary, $blui-blue-dark-accent, $blui-blue-dark-warn); | ||
| // } |
There was a problem hiding this comment.
Is this something we can just remove?
|
@JeffGreiner-eaton @JeanMeche The style issues are all going to need to be fixed in the themes or component repos. I'd recommend getting this merged and then addressing these issues with follow up stories in the appropriate repos. |
This commit add the support for Angular v15 (with legacy components).